Add migration for channel params #5640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chatton
requested review from
colin-axner,
AdityaSripal,
damiannolan,
crodriguezvega,
charleenfei and
DimitrisJim
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5640 +/- ##
=======================================
Coverage 81.16% 81.16%
=======================================
Files 198 199 +1
Lines 15267 15278 +11
=======================================
+ Hits 12392 12401 +9
- Misses 2407 2408 +1
- Partials 468 469 +1
|
DimitrisJim
reviewed
Jan 17, 2024
chatton
commented
Jan 17, 2024
e2e/testsuite/testconfig.go
Outdated
| @@ -561,7 +561,7 @@ func defaultGovv1ModifyGenesis(version string) func(ibc.ChainConfig, []byte) ([] | |||
| appState[govtypes.ModuleName] = govGenBz | |||
There was a problem hiding this comment.
linter fixes in this file
DimitrisJim
reviewed
Jan 17, 2024
DimitrisJim
approved these changes
Jan 17, 2024
damiannolan
approved these changes
Jan 17, 2024
|
I will merge to kick off the backport. |
crodriguezvega
deleted the
cian/issue#5639-add-migration-for-channel-params
branch
mergify bot
pushed a commit
that referenced
this pull request
Jan 18, 2024
* chore: adding channel params migration * chore: removed separate migration fn * chore: fix linter * chore: bump consensus * chore: fix linter again * chore: pr feedback --------- Co-authored-by: Carlos Rodriguez <carlos@interchain.io> (cherry picked from commit 59ac9b2)
crodriguezvega
pushed a commit
that referenced
this pull request
Jan 18, 2024
* chore: adding channel params migration * chore: removed separate migration fn * chore: fix linter * chore: bump consensus * chore: fix linter again * chore: pr feedback --------- Co-authored-by: Carlos Rodriguez <carlos@interchain.io> (cherry picked from commit 59ac9b2) Co-authored-by: Cian Hatton <cian@interchain.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #5639
An E2E upgrade test will be added in a follow up PR
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.